SimonG
/
GBase
1
0
Fork 0
Code Issues 24 Pull Requests Projects Releases Wiki Activity
Labels Milestones
New Issue

Is a seperate `FileHandler` really needed? #19

Open
opened 6 years ago by SimonG96 · 0 comments
SimonG96 commented 6 years ago (Migrated from github.com)
Owner

Currently there is a FileHandler and a DataHandler. The FileHandler basically only wraps the DataHandler right now:

8e08ba497d/GBase/FileHandling/FileHandler.cs (L33-L56)

If this is the only thing it is supposed to do it can probably just be removed.

Possible Reasons to keep:

  • Pending a decision on #12, it might be needed to handle interval data saving
  • Converting IGBaseTableEntries to a form where they can be handled by the IDataHandler
Currently there is a `FileHandler` and a `DataHandler`. The `FileHandler` basically only wraps the `DataHandler` right now: https://github.com/SimonG96/GBase/blob/8e08ba497d305eadc871f18d19398b48f00bd6c9/GBase/FileHandling/FileHandler.cs#L33-L56 If this is the only thing it is supposed to do it can probably just be removed. **Possible Reasons to keep:** - Pending a decision on #12, it might be needed to handle interval data saving - Converting `IGBaseTableEntries` to a form where they can be handled by the `IDataHandler`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
ImproveDataHandling_#25
OldDataHandling
master
Labels
Apply labels
Clear labels
API
Issues or features related to the API Authorization
Issues or features related to the Authorization between client and server bug
Something isn't working Cache
Issues or features related to the Cache DatabaseClient
Issues or features related to the DatabaseClient DatabaseServer
Issues or features related to the DatabaseServer DataHandling
Issues or features related to DataHandling documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request FileHandling
Issues or features related to FileHandling GBase
Issues or features related to the GBase good first issue
Good for newcomers help wanted
Extra attention is needed Initialization
Issues or features related to the Initialization invalid
This doesn't seem right IocContainer
Issues or features related to the IocContainer LocalDatabase
Issues or features related to the local Database Performance
Issues or features related to performance question
Further information is requested Refactoring
Issues or features related to Refactoring Security
Issues or features related to security Service
Issues or features related to the Services Test
Issues or features describing a test wontfix
This will not be worked on
No Label API Authorization bug Cache DatabaseClient DatabaseServer DataHandling documentation duplicate enhancement FileHandling GBase good first issue help wanted Initialization invalid IocContainer LocalDatabase Performance question Refactoring Security Service Test wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Backlog
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SimonG/GBase#19
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes